Deprecate logger::provider() and logger::instrumentation_scope() #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 26, 2024
Co-authored-by: Cijo Thomas <[email protected]>
cijothomas
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 123 123
Lines 21371 21366 -5
=======================================
- Hits 17006 17000 -6
- Misses 4365 4366 +1 ☔ View full report in Codecov by Sentry. |
utpilla
approved these changes
Nov 26, 2024
pitoniak32
pushed a commit
to pitoniak32/opentelemetry-rust
that referenced
this pull request
Dec 4, 2024
…n-telemetry#2349) Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecating these methods. The methods were meant to be used by appenders, and they can always keep hold to the
providerhandle to get this data. We can anyway have additive changes even after stable release, so safe to remove it for now. Thanks for noticing them @utpilla :)Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes